Skip to content

fix(tiers): hide Wasabi from provider selection - #295

Merged
cxymds merged 1 commit into
mainfrom
cxymds/remove-wasabi-tier
Nov 12, 2026
Merged

cxymds merged 1 commit into
mainfrom
cxymds/remove-wasabi-tier

Conversation

@cxymds

@cxymds cxymds commented Nov 12, 2026

Copy link
Copy Markdown
Member

Pull Request

Description

Hide the disabled Wasabi option from the Add Tier provider picker while retaining its configuration, form, payload, existing-tier management, translations, and assets for a future return. Add an English comment explaining that future workflow and scenario improvements are planned.

The other seven provider options keep their existing order and behavior.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Code refactoring
  • Performance improvement
  • Test improvements
  • Security fix

Testing

  • Unit tests added/updated
  • Manual testing completed
pnpm install --frozen-lockfile
pnpm type-check
pnpm lint
pnpm format:check
pnpm test:run
git diff --check

All 946 tests passed. Browser checks against the running Console with local HTTP fixtures confirmed eight provider options before the change and seven afterward, with no Wasabi option on desktop or mobile. Existing Wasabi tier data still appears in the list with its management actions. Selecting AWS S3 focuses the name field; returning to the picker restores focus to AWS S3.

Checklist

  • Code follows the project's style guidelines
  • Self-review completed
  • TypeScript types are properly defined
  • All commit messages are in English (Conventional Commits)
  • All existing tests pass
  • No new dependencies added, or they are justified

Related Issues

Requested task: temporarily hide Wasabi from the tier provider picker, retaining support for future workflow and scenario improvements.

Screenshots (if applicable)

Running Console with identical local HTTP fixtures, Chinese locale, and light theme. Desktop: 1440 × 1000. Mobile: 390 × 844, scrolled to the end of the provider list.

Desktop before Desktop after
Wasabi shown as a disabled option Wasabi hidden from the picker
Mobile before Mobile after
Mobile picker with Wasabi Mobile picker ending with Cloudflare R2

Additional Notes

Screenshots are stored on a separate evidence branch and do not add assets to the implementation diff. Browser fixtures verify frontend behavior; no live RustFS integration was exercised.

Keep Wasabi support available for future workflow and scenario improvements while hiding its entry from the new tier picker.
Copilot AI balanced review requested due to automatic review settings November 12, 2026 09:11
@cxymds
cxymds merged commit 4aeb19c into main Nov 12, 2026
11 checks passed
@cxymds
cxymds deleted the cxymds/remove-wasabi-tier branch November 12, 2026 09:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues remain for the change hiding Wasabi from the Add Tier provider picker.

No open issues 🎉

What changed in this PR

Temporarily hides Wasabi from the Add Tier provider picker while preserving its underlying support and existing-tier management. The other seven providers retain their order and behavior.

Changes:

  • Filters Wasabi out of the picker and adds a comment explaining its planned return after workflow and scenario improvements.
  • Updates the source-based regression test to check that Wasabi is hidden while existing support remains intact.
File Description
tests/​lib/​tier-support-source.test.js Adds an assertion for the Wasabi picker filter and updates the test name.
components/​tiers/​new-form.tsx Excludes Wasabi from rendered provider options and documents why.

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants