Repository navigation
fix(tiers): hide Wasabi from provider selection - #295
Merged
Merged
Conversation
Keep Wasabi support available for future workflow and scenario improvements while hiding its entry from the new tier picker.
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues remain for the change hiding Wasabi from the Add Tier provider picker.
No open issues 🎉
What changed in this PR
Temporarily hides Wasabi from the Add Tier provider picker while preserving its underlying support and existing-tier management. The other seven providers retain their order and behavior.
Changes:
- Filters Wasabi out of the picker and adds a comment explaining its planned return after workflow and scenario improvements.
- Updates the source-based regression test to check that Wasabi is hidden while existing support remains intact.
| File | Description |
|---|---|
tests/lib/tier-support-source.test.js |
Adds an assertion for the Wasabi picker filter and updates the test name. |
components/tiers/new-form.tsx |
Excludes Wasabi from rendered provider options and documents why. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Hide the disabled Wasabi option from the Add Tier provider picker while retaining its configuration, form, payload, existing-tier management, translations, and assets for a future return. Add an English comment explaining that future workflow and scenario improvements are planned.
The other seven provider options keep their existing order and behavior.
Type of Change
Testing
All 946 tests passed. Browser checks against the running Console with local HTTP fixtures confirmed eight provider options before the change and seven afterward, with no Wasabi option on desktop or mobile. Existing Wasabi tier data still appears in the list with its management actions. Selecting AWS S3 focuses the name field; returning to the picker restores focus to AWS S3.
Checklist
Related Issues
Requested task: temporarily hide Wasabi from the tier provider picker, retaining support for future workflow and scenario improvements.
Screenshots (if applicable)
Running Console with identical local HTTP fixtures, Chinese locale, and light theme. Desktop: 1440 × 1000. Mobile: 390 × 844, scrolled to the end of the provider list.
Additional Notes
Screenshots are stored on a separate evidence branch and do not add assets to the implementation diff. Browser fixtures verify frontend behavior; no live RustFS integration was exercised.