Skip to content

fix(kms): schedule a deletion before destroying a key in KMS-208 #150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
reatang wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(kms): schedule a deletion before destroying a key in KMS-208 #150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions rustfs-kms-test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1152,11 +1152,23 @@ test_kms208() {
echo "immediate deletion unexpectedly allowed"; return 1
fi
echo "expected rejection of unconfirmed immediate deletion (HTTP ${code}): ${body}"
# positive path: env flag on + explicit confirm -> unreferenced key destroyed
# Destruction is two steps: a confirmed immediate request against a key that
# was never scheduled must be refused and must leave the key usable.
kms_create_key "k208b" "env=ci" || return 1
local kid2="${KMS_KEY_ID}"
local kid2="${KMS_KEY_ID}" st
body="$(admin_api DELETE /rustfs/admin/v3/kms/keys/delete "" "{\"key_id\":\"${kid2}\",\"force_immediate\":true,\"confirm_key_id\":\"${kid2}\"}")"; code="$(admin_api_code)"
[ "${code}" = "400" ] || { echo "immediate deletion of an unscheduled key -> HTTP ${code}, expected 400: ${body}"; return 1; }
st="$(kms_describe_key "${kid2}")" || return 1
if printf '%s' "${st}" | grep -qiE 'pending'; then echo "refused immediate deletion still scheduled the key: ${st}"; return 1; fi
printf '%s' "${st}" | grep -qiE 'active|enabled|available|usable|ready' || { echo "key not usable after refused immediate deletion: ${st}"; return 1; }
# positive path: schedule first, then env flag on + explicit confirm destroys
# the pending key without waiting out its window
body="$(admin_api DELETE /rustfs/admin/v3/kms/keys/delete "" "{\"key_id\":\"${kid2}\",\"pending_window_in_days\":7}")"; code="$(admin_api_code)"
[ "${code}" = "200" ] || { echo "scheduling deletion failed: HTTP ${code}: ${body}"; return 1; }
body="$(admin_api DELETE /rustfs/admin/v3/kms/keys/delete "" "{\"key_id\":\"${kid2}\",\"force_immediate\":true,\"confirm_key_id\":\"${kid2}\"}")"; code="$(admin_api_code)"
[ "${code}" = "200" ] || { echo "confirmed immediate deletion failed: HTTP ${code}: ${body}"; return 1; }
[ "${code}" = "200" ] || { echo "confirmed immediate deletion of a pending key failed: HTTP ${code}: ${body}"; return 1; }
body="$(admin_api GET "/rustfs/admin/v3/kms/keys/${kid2}" "")"; code="$(admin_api_code)"
[ "${code}" = "404" ] || { echo "destroyed key still answers HTTP ${code}: ${body}"; return 1; }
}

test_kms209() {
Expand Down
Loading