Repository navigation
fix(chain): wait for the nightly build race; guard manual quarantine - #141
Merged
Merged
Conversation
The nightly build dispatches the functional chain from a late step, seconds before the run reaches completed/success. On Nov 4 the chain resolved 12 s too early and died at prepare (run 41872426981: 'candidate attempt has not completed successfully') — no lane ran. The resolver now polls up to 10 min for the referenced attempt to finish before failing. The sweep quarantine recovery could also delete markers it must never touch: manual markers (authorized performance baselines) carry no run_id. Recovery is now restricted to functional-fleet markers owned by a numeric CI run id whose run is no longer queued/in_progress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1. Nightly build dispatch race
Last night's chain (41872426981) died at prepare:
candidate attempt has not completed successfully.Timeline: the nightly build finished at 16:55:57, the chain was dispatched at 16:55:45 — the resolver ran 12 s before the build reached completed/success. (The night before, the build finished 2 min before dispatch, so the latent race never fired.)
Fix:
resolve()now polls the referenced attempt up to 10 min before failing, instead of failing instantly.2. Manual-quarantine guard (complements #140)
The sweep's stale-quarantine recovery would also delete markers it must never touch: manual markers (e.g. the authorized four-node gRPC performance baseline running since Nov 4 16:13 UTC) carry no
run_id. Recovery is now restricted torustfs-shared-functional-tests-v2markers owned by a numeric CI run id whose run is no longer queued/in_progress; anything else is reported and left alone.