Repository navigation
fix(heal-sweep): read the case verdict from its real path - #136
Merged
Merged
Conversation
The smoke run (41748362310) exposed two mapping bugs: the result JSON was read from run/cases/<id>.json but run_validation_case.sh writes it to run/<id>/cases/<id>.json, so every verdict came back empty; and rc=0 with no verdict was then recorded as FAIL even though the runner succeeded (healthy-noop's own report shows PASS). The terminal verdict is now authoritative when present, otherwise rc=0 -> PASS. Also raise the per-case cap to 1800s (admin-overlap-and-force-start runs eight deployment branches and legitimately exceeded 900s) and the loop budget to 540 min.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smoke run (41748362310) proved the pipeline works (tools build → download → verify → execute) but exposed two mapping bugs that mislabeled every case:
run/cases/<id>.json, butrun_validation_case.shpasses--validation-artifacts-dir run/<id>so the verdict is atrun/<id>/cases/<id>.json. Every verdict came back empty.heal.admin-healthy-noopexited 0 with a PASS report yet was recorded FAIL.Mapping now: terminal verdict authoritative (PASS/BLOCKED); no verdict → trust rc (0 = PASS, 124 = TIMEOUT, else FAIL).
Also: per-case cap 900 s → 1800 s (
admin-overlap-and-force-startruns eight deployment branches and legitimately exceeded 900 s), loop budget 480 → 540 min.Smoke evidence: 3 of 5 cases exited 0 (likely PASS once mapped correctly);
admin-scope-isolationexited 1 (needs re-examination with the fixed path); 1 genuine 900 s timeout.