Repository navigation
Clippy lints - #332
Clippy lints#332EdJoPaTo wants to merge 14 commits into
Conversation
| unused_qualifications = "warn" | ||
| variant_size_differences = "warn" | ||
| [lints.clippy] | ||
| pedantic = { level = "warn", priority = -1 } |
There was a problem hiding this comment.
Some of the changes presented are worthwhile, but this is not something I want to maintain here.
There was a problem hiding this comment.
Not entirely sure whether I understand this comment. Enabling a lint group that hints more things is too annoying?
Not sure what to change here, feel free to drop commits or decline the PR all together?
There was a problem hiding this comment.
That specific lint group pedantic. I am unwilling to unconditionally enable it in this project.
It is an opinionated lint group, some projects use it as you do here, some don't. It implies it certain amount of churn. In this project, I do not want that.
So, I am willing to take the move of the Clippy lints to Cargo.toml, the CI extension, but not enabling the pendantic lint group and what follows based on that.
Not sure what to change here, feel free to drop commits or decline the PR all together?
You are capable of reworking the PR. I am not lacking PR to review over various FOSS projects, so if you are not interested in reworking it yourself, please signal that by closing it.
Apply a bunch of lints to improve and ensure code quality.
Each change is in its own commit so it's easy to drop a single change.