Skip to content

Remove the 'sub' method from 'At' and migrate to 'sub_raw' - #164303

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fallible-algebra:at-removal/remove-sub
Oct 26, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
fallible-algebra:at-removal/remove-sub

Conversation

@fallible-algebra

@fallible-algebra fallible-algebra commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Continuation of #163978, similar scope to #164244.

@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in engine.rs, potentially modifying the public API of ObligationCtxt.

cc @lcnr

changes to the core type system

cc @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 14, 2026
@rustbot

rustbot commented Oct 14, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 77 candidates
  • Random selection from 18 candidates

@fallible-algebra

Copy link
Copy Markdown
Member Author

r? lcnr

@rustbot rustbot assigned lcnr and unassigned jieyouxu Oct 14, 2026
@rustbot

rustbot commented Oct 19, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@lcnr

lcnr commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@bors r+ rollup

@rust-bors

rust-bors Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 20986b6 has been approved by lcnr

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 26, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 26, 2026
…-sub, r=lcnr

Remove the 'sub' method from 'At' and migrate to 'sub_raw'

Continuation of rust-lang#163978, similar scope to rust-lang#164244.
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #164955 (Use the updated buffer length in UEFI locate_handles)
 - #164958 (uefi: roll back env changes when `start_image` fails)
 - #164968 (thread_local::guard: update comments a bit)
 - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw')
 - #164674 (Use a NoSpan marker for region constraints without spans)
 - #164856 (Switch from `insta` to `expect-test` in bootstrap)
 - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads)
 - #164954 (Reduce `SpanData` use)
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
…uwer

Rollup of 8 pull requests

Successful merges:

 - #164955 (Use the updated buffer length in UEFI locate_handles)
 - #164958 (uefi: roll back env changes when `start_image` fails)
 - #164968 (thread_local::guard: update comments a bit)
 - #164303 (Remove the 'sub' method from 'At' and migrate to 'sub_raw')
 - #164674 (Use a NoSpan marker for region constraints without spans)
 - #164934 (Remove redundant vec and duplicate indexing in find_noop_landing_pads)
 - #164954 (Reduce `SpanData` use)
 - #164970 (`rust-analyzer` subtree update)
@rust-bors
rust-bors Bot merged commit 406d90c into rust-lang:main Oct 26, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 26, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 26, 2026
Rollup merge of #164303 - fallible-algebra:at-removal/remove-sub, r=lcnr

Remove the 'sub' method from 'At' and migrate to 'sub_raw'

Continuation of #163978, similar scope to #164244.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants