[ChrisDenton]

View all comments

[ChrisDenton]

@bors try

[ChrisDenton]

cc @clarfonthey as you've expressed an interest here. I'll do a crater run here if try is successful but I do feel very strongly that our internals should be internal so if there is a problem I'd at least like to #[deprecate] with an intent to make it properly unstable in the future.

[ChrisDenton]

Hm, for some reason the try build isn't being picked up. Let me try again:

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: 67a539c (67a539cbdf2a0107837ce64f9069509a44da67b7)
Base parent: 69bccf0 (69bccf03c4733f57482f9691456efcd80f86a5f6)

[ChrisDenton]

@craterbot check

[craterbot]

👌 Experiment pr-164053 created and queued.
🤖 Automatically detected try build 67a539c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[theemathas]

Crater rollup in #164148

@craterbot abort

[craterbot]

🗑️ Experiment pr-164053 deleted!

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[theemathas]

@craterbot check crates=https://crater-reports.s3.amazonaws.com/pr-164148-crater-rollup/retry-regressed-list.txt p=1

[craterbot]

👌 Experiment pr-164053 created and queued.
🤖 Automatically detected try build 67a539c
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[theemathas]

The fontdue crate (dependency of miniquad and macroquad) uses vec::from_elem. https://github.com/mooman219/fontdue/blob/2924772fb4439b8aca40b1bffca70088acba5a1b/src/font.rs#L287

[clarfonthey]

Yeah I mean, this is kind of what I expected to happen, although we'll see how many breakages there are.

[folkertdev]

Opened mooman219/fontdue#173, may as well get that sorted out sooner rather than later. Luckily most users are on the latest patch release so will likely upgrade to a next patch release automatically.

[mooman219]

I assume this is going to need a #[deprecated] given there is usage of it. I've published the patch to omit my usage in the meantime.

I surfaced this API from using rust analyzer. It recommended the function at the time and it seemed to fit what I wanted. This was a long time ago at this point, and #[doc(hidden)] might have been less respected by RA.

[craterbot]

🚧 Experiment pr-164053 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[craterbot]

🎉 Experiment pr-164053 is completed!
📊 3583 regressed and 0 fixed (28882 total)
📊 999 spurious results on the retry-regressed-list.txt, consider a retry¹ if this is a significant amount.
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

Footnotes

1. re-run the experiment with crates=https://crater-reports.s3.amazonaws.com/pr-164053/retry-regressed-list.txt ↩

[clarfonthey]

Yeah, as expected, will want at least a deprecation/FCW on this rather than immediate merging. 50 top-level crates is unfortunate but not unfixable and doesn't mean we can't remove it eventually, just, not right now.

[clarfonthey]

@rustbot author

[folkertdev]

It's really mostly fontdue and then cryptoxide which I've also submitted a PR to. It's also a bunch of older versions for fontdue which based on crates.io get relatively few downloads. So, it's more nuanced than the raw number.

But yeah deprecating first does seem like the way to go.

[ChrisDenton]

I think this experiment has served its purpose so I'll close this now. I'll put up a new PR deprecating vec::from_elem. We can revisit destabilization later.

[ChrisDenton]

See #164653