Conversation
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @clarfonthey (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. Why was this reviewer chosen?The reviewer was selected based on:
|
5 tasks
clarfonthey
reviewed
Sep 17, 2026
Contributor
|
LGTM minus test splitting. @rustbot author |
Collaborator
|
Reminder, once the PR becomes ready for a review, use |
json420
marked this pull request as draft
September 17, 2026 21:50
json420
marked this pull request as ready for review
September 18, 2026 19:11
Author
|
@rustbot ready |
Contributor
|
@bors r+ rollup Thank you! |
Contributor
Author
|
@clarfonthey No, thank you! Contributing to Rust is, like, a wildly pleasant experience for a first timer! Seriously. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue: #162868
This adds
.seek_read_exact()tostd::os::windows::fs::FileExt, an exact port ofread_exact_at()forstd::os::unix::fs::FileExt.And it adds
.seek_write_all()tostd::os::windows::fs::FileExt, an exact port ofwrite_all_at()forstd::os::unix::fs::FileExt.Finally, it adds six tests.
First there is a smoke test for
seek_read_exact(),seek_write_all(), an exact port of the test for the.seek_read(),.seek_write()methods. This is to make sure we are getting the same pass-through behavior through the lens of established tests.Then there are five tests for the
windows::fs::FileExttrait itself, covering allseek_read_exact(),seek_write_all()corner cases exceptio::ErrorKind::Interrupted(advise welcome on that one). These tests use mock implementations of the traitsseek_read()andseek_write()methods.No LLMs were used in writing this PR.