Make the last non-breaking box impl generalizations

[maxdexh]

View all comments

Follow-up to #161946

r? clarfonthey

[rustbot]

clarfonthey is currently at their maximum review capacity.
They may take a while to respond.

[maxdexh]

Feel free to reassign, close or whatever. Like I said I only created this PR because it was really quick to write

[clarfonthey]

(Just set capacity to 0 for rustconf. I don't mind reviewing.)

[clarfonthey]

@craterbot check

[craterbot]

🚨 Error: missing start toolchain

🆘 If you have any trouble with Crater please ask in t-infra on Zulip
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

[clarfonthey]

@bors try @rust-timer queue

[rust-bors]

💔 Test for b8108b0 failed: CI. Failed jobs:

• try - dist-aarch64-linux-quick (web logs, enhanced plaintext logs)
• try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

[maxdexh]

/home/ubuntu/actions-runner/_work/_temp/8c23750a-bf19-4bb9-b479-e058e0167563.sh: line 1: git: command not found what 😂

@rustbot ready

[clarfonthey]

@bors try

[rust-bors]

💔 Test for 5038223 failed: CI. Failed jobs:

• try - dist-aarch64-linux-quick (web logs, enhanced plaintext logs)
• try - dist-x86_64-linux-quick (web logs, enhanced plaintext logs)

[maxdexh]

bors does not approve

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[maxdexh]

It looks like CI is just broken atm: https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Tree.20ops/near/623200074

[clarfonthey]

I guess Fish is too occupied at the Foundation table at RustConf.

[maxdexh]

Can we have a waiting-on-git label? ^^

[rust-log-analyzer]

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[Mark-Simulacrum]

@bors try

[rust-bors]

☀️ Try build successful (CI)
Build commit: a621e2b (a621e2b446eafb53c7a8569f225e0b8cc2429a68)
Base parent: 018018e (018018e881e2db0956f229dbb543e21f058d1ce7)

[rust-timer]

Finished benchmarking commit (a621e2b): comparison URL.

Overall result: no relevant changes - no action needed

Benchmarking means the PR may be perf-sensitive. Consider adding rollup=never if this change is not fit for rolling up.

@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary 0.1%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.5%	[0.5%, 0.5%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.5%	[-0.6%, -0.4%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.1%	[-0.6%, 0.5%]	5

Cycles

Results (primary 0.4%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.4%, 1.2%]	8
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.9%	[-1.0%, -0.7%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.4%	[-1.0%, 1.2%]	10

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 479.823s -> 480.026s (0.04%)
Artifact size: 403.70 MiB -> 403.81 MiB (0.03%)

[maxdexh]

@clarfonthey wanna try running crater again?