Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits - #162275
Open
adwinwhite wants to merge 1 commit into
Open
Do not increase recursion depth for coroutine witness and rigid opaques when proving auto traits#162275adwinwhite wants to merge 1 commit into
adwinwhite wants to merge 1 commit into
Conversation
adwinwhite
marked this pull request as ready for review
September 4, 2026 06:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With deeply nested async calls, we can easily overflow evaluating auto trait goals as shown in #159228.
Users have no choice but increase the per-crate
recursion_limitwhich is bad for compilation time/RSS. And downstream users may encounter the same warnings when calling library async functions.We mitigate that by no longer increasing recursion depth for coroutine witness and rigid opaques when proving auto traits. See the comments for why it's okay to do so.
This fix actually makes the required depth a third of what it was before for async calls.
I've checked locally that
borsandtriagebotno longer have FCWs.r? lcnr