cargotest: add lockfiles by jnkel · Pull Request #162265 · rust-lang/rust

jnkel · 2026-09-03T22:56:55Z

The cargotest suite clones (specific commit hashes of) some repos from GitHub and builds them. One such repo (iron) had no lockfile, and one of its dependencies (tinyvec) pushed an update which failes to compile.

Add a lockfile for this test to downgrade tinyvec, unblock CI, and prevent this from happening in the future. Also add lockfiles for other tests that were missing them (diesel and stylo), as not having them risks both broken builds and supply-chain attacks on CI.

rustbot · 2026-09-03T22:57:01Z

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

Fallback group: @Mark-Simulacrum, @jieyouxu
@Mark-Simulacrum, @jieyouxu expanded to Mark-Simulacrum, jieyouxu

ChrisDenton · 2026-09-04T03:13:21Z

I'm not entirely sure which team cargotest comes under but r=me if you want to get things moving again.

jnkel · 2026-09-04T05:37:37Z

A fixed release of tinyvec has been published so the tree is no longer blocked. The PR is still worth merging IMO, but there's no rush on it.

JonathanBrouwer · 2026-09-04T08:29:51Z

@bors try jobs=x86_64-gnu-aux

cargotest: add lockfiles try-job: x86_64-gnu-aux

jieyouxu · 2026-09-04T09:47:40Z

I'm not entirely sure which team cargotest comes under but r=me if you want to get things moving again.

AFAIK cargotest is more of a historic relic that exercises some basic ecosystem crate for "nothing is obviously entirely borked". I would say somewhere in between compiler/bootstrap/cargo but in practice, no one is actually actively maintaining this.

Looks like this was introduced way back in #32348. Alex did indeed very astutely note #32348 (comment)

Looks good to me, although I do think that we'll want to check in a lock file to ensure that tests don't break to unintended consequences.

jieyouxu

Thanks, incrementally covering more of these w/ lockfiles is strictly better than the previous status quo.

You can r= Chris and me with these two nits

@rustbot author

View changes since this review

jieyouxu · 2026-09-04T10:08:12Z

Apparently the infra team was maintaining cargotest. I did not know that. Looking back at #70659...

Well it turns out I did know. I just forgot: #t-infra > Who's maintaining cargotest?

rust-bors · 2026-09-04T11:04:23Z

☀️ Try build successful (CI)
Build commit: 43d03dc (43d03dcca17e79764ee54e2e4605782d28548477)
Base parent: 71238e2 (71238e21fc55e73ab3aad8c9f79fed7a47a179e1)

rustbot · 2026-09-04T13:02:53Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

jnkel · 2026-09-04T14:28:43Z

@rustbot ready

(I don't think I have permission to r=Chris and you)

jieyouxu

Thanks
@bors r+ rollup

View changes since this review

rust-bors · 2026-09-05T08:59:59Z

📌 Commit 70e0d6d has been approved by jieyouxu

It is now in the queue for this repository.

🌲 The tree is currently closed for pull requests below priority 10. This pull request will be tested once the tree is reopened.

Reason for tree closure: Linux x64 EC2 instances are not starting

cargotest: add lockfiles The `cargotest` suite clones (specific commit hashes of) some repos from GitHub and builds them. One such repo ([iron](https://github.com/iron/iron)) had no lockfile, and one of its dependencies (`tinyvec`) [pushed an update which failes to compile](Lokathor/tinyvec#225). Add a lockfile for this test to downgrade tinyvec, unblock CI, and prevent this from happening in the future. Also add lockfiles for other tests that were missing them (`diesel` and `stylo`), as not having them risks both broken builds and supply-chain attacks on CI.

Rollup of 14 pull requests Successful merges: - #162324 (miri subtree update) - #162170 (bootstrap: use target's LLVM libdir when cross-compiling) - #158312 (Adds support for AArch64 SVE to inline assembly) - #159792 (A more readable debug map for IndexMaps) - #160745 (make closures act like MaybeDangling) - #161263 (break rustc_expand-rustc_middle dependency) - #161895 (std::sys::pal::sgx: fix mismatched alloc/free alignment) - #161940 (Promote `wasm32-wasip3` to a tier 2 target) - #161397 (coverage: Tidy tests and add some new ones) - #161616 (Report precondition violation for `<usize as SliceIndex>::get_unchecked` in const-eval) - #162248 (Add regression test for unsized const parameter default ICE) - #162250 (Fix hashing of span end columns in incremental compilation) - #162265 (cargotest: add lockfiles) - #162318 (bootstrap: Fix broken path for `./x doc compiler/rustc --open`)

Rollup merge of #162265 - jnkel:cargotest-lockfile, r=jieyouxu cargotest: add lockfiles The `cargotest` suite clones (specific commit hashes of) some repos from GitHub and builds them. One such repo ([iron](https://github.com/iron/iron)) had no lockfile, and one of its dependencies (`tinyvec`) [pushed an update which failes to compile](Lokathor/tinyvec#225). Add a lockfile for this test to downgrade tinyvec, unblock CI, and prevent this from happening in the future. Also add lockfiles for other tests that were missing them (`diesel` and `stylo`), as not having them risks both broken builds and supply-chain attacks on CI.

rustbot assigned Mark-Simulacrum Sep 3, 2026

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Sep 3, 2026

jnkel marked this pull request as draft September 3, 2026 23:01

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 3, 2026

jnkel force-pushed the cargotest-lockfile branch from e76720f to 16d7f60 Compare September 3, 2026 23:14

jnkel marked this pull request as ready for review September 3, 2026 23:14

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 3, 2026

jnkel changed the title ~~cargotest: add lockfile for iron~~ cargotest: add lockfiles Sep 3, 2026

This was referenced Sep 3, 2026

[beta] backports #162258

Merged

Rollup of 12 pull requests #162254

Merged

This comment has been minimized.

Sign in to view

rust-bors Bot pushed a commit that referenced this pull request Sep 4, 2026

Auto merge of #162265 - jnkel:cargotest-lockfile, r=<try>

43d03dc

cargotest: add lockfiles try-job: x86_64-gnu-aux

jieyouxu approved these changes Sep 4, 2026

View reviewed changes

Comment thread src/tools/cargotest/main.rs Outdated

Comment thread src/tools/cargotest/main.rs Outdated

jieyouxu assigned jieyouxu and unassigned Mark-Simulacrum Sep 4, 2026

jieyouxu reviewed Sep 4, 2026

View reviewed changes

Comment thread src/tools/cargotest/lockfiles/diesel.lock

rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 4, 2026

cargotest: ensure all tests have lockfiles

70e0d6d

jnkel force-pushed the cargotest-lockfile branch from 16d7f60 to 70e0d6d Compare September 4, 2026 14:28

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 4, 2026

jieyouxu approved these changes Sep 5, 2026

View reviewed changes

rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 5, 2026

JonathanBrouwer mentioned this pull request Sep 5, 2026

Rollup of 14 pull requests #162327

Closed

Zalathar mentioned this pull request Sep 5, 2026

Rollup of 14 pull requests #162333

Merged

rust-bors Bot merged commit 5fdb088 into rust-lang:main Sep 5, 2026
13 checks passed

rustbot added this to the 1.100.0 milestone Sep 5, 2026

Uh oh!

Uh oh!

Conversation

jnkel commented Sep 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Sep 3, 2026

Uh oh!

ChrisDenton commented Sep 4, 2026

Uh oh!

jnkel commented Sep 4, 2026

Uh oh!

JonathanBrouwer commented Sep 4, 2026

Uh oh!

This comment has been minimized.

jieyouxu commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jieyouxu left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jieyouxu commented Sep 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

rust-bors Bot commented Sep 4, 2026

Uh oh!

rustbot commented Sep 4, 2026

Uh oh!

jnkel commented Sep 4, 2026

Uh oh!

jieyouxu left a comment • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rust-bors Bot commented Sep 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jnkel commented Sep 3, 2026 •

edited

Loading

jieyouxu commented Sep 4, 2026 •

edited

Loading

jieyouxu left a comment •

edited

Loading

jieyouxu commented Sep 4, 2026 •

edited

Loading

jieyouxu left a comment •

edited by rustbot

Loading