Skip to content

convert rustc_hir::Target inherent methods to From impls - #160110

Open
mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:target_impls
Open

convert rustc_hir::Target inherent methods to From impls#160110
mejrs wants to merge 1 commit into
rust-lang:mainfrom
mejrs:target_impls

Conversation

@mejrs

@mejrs mejrs commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Part of a plan to move it and Attribute to a attribute-only crate below rustc_hir, where these inherent impls will no longer be possible

Part of a plan to move it and Attribute to a attribute-only crate below rustc_hir, where these inherent impls will no longer be possible
@rustbot

rustbot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann, @JonathanBrouwer

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 28, 2026
@rustbot

rustbot commented Jul 28, 2026

Copy link
Copy Markdown
Collaborator

r? @oli-obk

rustbot has assigned @oli-obk.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 74 candidates
  • Random selection from 16 candidates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants