compiletest: forward disable-minification from bootstrap - #159887
compiletest: forward disable-minification from bootstrap#159887AayushMainali-Github wants to merge 1 commit into
Conversation
Honor build.docs-minification=false for rustdoc suites run via compiletest by forwarding --disable-minification to rustdoc.
|
Some changes occurred in src/tools/compiletest cc @jieyouxu
|
|
Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
Why was this reviewer chosen?The reviewer was selected based on:
|
|
r? rustdoc can individual tests override this flag? or... would they want to? is that useful? |
|
No per-test override here. Tests can already add rustdoc flags via |
|
☔ The latest upstream changes (presumably #160284) made this pull request unmergeable. Please resolve the merge conflicts by rebasing. |
build.docs-minification = falsewas already honored when building docs through bootstrap's doc steps, but compiletest-driven rustdoc suites always generated minified CSS/JS.Bootstrap now forwards
--disable-minificationto compiletest when docs minification is disabled, and compiletest passes-Zunstable-options --disable-minificationto rustdoc for HTML/JS/JSON/UI doc generation.Fixes #142737.