Skip to content

Next steps for FnDef binder changes (instantiate most FnDef binders) - #159403

Open
addiesh wants to merge 1 commit into
rust-lang:mainfrom
addiesh:call-me-turbofishmael
Open

Next steps for FnDef binder changes (instantiate most FnDef binders)#159403
addiesh wants to merge 1 commit into
rust-lang:mainfrom
addiesh:call-me-turbofishmael

Conversation

@addiesh

@addiesh addiesh commented Jul 16, 2026 •
edited
Loading

Copy link
Copy Markdown

View all comments

This change is a part of the ongoing effort to clean up binder/turbofishing behavior in the compiler (#156581).

This PR instantiates binders that were previously created via ty::Binder::dummy() with meaningfully bound vars.

r? oli-obk

Call me Turbofishmael.
Some years ago- never mind how long precisely-
having little or no money in my purse,
and nothing particular to interest me in C++,
I thought I would sail about a little and see the rusty part of the world.

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. PG-exploit-mitigations Project group: Exploit mitigations S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Jul 16, 2026
@rustbot

rustbot commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Thanks for the pull request, and welcome! The Rust Project is excited to review your changes, and you should hear from @oli-obk (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@addiesh
addiesh force-pushed the call-me-turbofishmael branch 3 times, most recently from 014b214 to d780036 Compare July 16, 2026 19:40
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh

This comment was marked as resolved.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from d780036 to 6e740ba Compare July 16, 2026 20:10
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 330681e to 83e428c Compare July 17, 2026 15:14
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh addiesh mentioned this pull request Jul 17, 2026
Open
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 83e428c to 9fb9767 Compare July 17, 2026 17:18
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 9fb9767 to 3920a9e Compare July 17, 2026 22:34
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 5373d53 to f118249 Compare July 20, 2026 15:15
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from f118249 to 6aeb29e Compare July 20, 2026 15:28
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 6aeb29e to ac8e8e5 Compare July 20, 2026 15:33
@addiesh
addiesh marked this pull request as ready for review July 20, 2026 15:48
@rust-bors

This comment has been minimized.

Sign in to view
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) A-CI Area: Our Github Actions CI A-meta Area: Issues & PRs about the rust-lang/rust repository itself A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-run-make Area: port run-make Makefiles to rmake.rs A-rustc-dev-guide Area: rustc-dev-guide A-testsuite Area: The testsuite used to check the correctness of rustc O-unix Operating system: Unix-like T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. labels Jul 29, 2026
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 1047fdb to d8350cc Compare July 29, 2026 14:33
@rustbot

This comment has been minimized.

Sign in to view
@addiesh

This comment was marked as resolved.

Sign in to view
addiesh
addiesh commented Jul 29, 2026
View reviewed changes
Comment thread tests/ui/generics/binder-arg-overflow-regression-133613.rs Outdated
@addiesh
addiesh force-pushed the call-me-turbofishmael branch from d8350cc to 85d2121 Compare July 29, 2026 14:52
@rustbot

This comment was marked as outdated.

Sign in to view
@rustbot rustbot added A-rustdoc-js Area: Rustdoc's JS front-end A-tidy Area: The tidy tool O-windows Operating system: Windows labels Jul 31, 2026
@rustbot

This comment has been minimized.

Sign in to view
@addiesh

addiesh commented Jul 31, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

ohhh no
(context to anyone who got pinged by rustbot: i messed up a rebase. you should be able to ignore this 😅️)

@GuillaumeGomez

GuillaumeGomez commented Jul 31, 2026

Copy link
Copy Markdown
Member

git reflog will be your friend here. 😉

@addiesh
addiesh force-pushed the call-me-turbofishmael branch 2 times, most recently from 85d2121 to 71f6804 Compare July 31, 2026 15:36
@rustbot

rustbot commented Jul 31, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@addiesh
addiesh force-pushed the call-me-turbofishmael branch from 71f6804 to a66936d Compare July 31, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oli-obk oli-obk oli-obk requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@oli-obk oli-obk

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) A-testsuite Area: The testsuite used to check the correctness of rustc perf-regression Performance regression. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@addiesh @rustbot @rust-log-analyzer @oli-obk @rust-timer @GuillaumeGomez @jieyouxu