When compiling without a specified --edition, emit a note

[estebank]

No description provided.

[estebank]

I'll try to write an MCP later (unless someone does it for me). This change was motivated after seeing https://internals.rust-lang.org/t/code-compiles-on-playground-but-fails-when-passed-via-stdin-to-rustc/24393 where the different defaults between cargo, playground and rustc caused people to get confused.

[rustbot]

Some changes occurred in src/tools/compiletest

cc @jieyouxu

[rustbot]

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

• Owners of files modified in this PR: compiler
• compiler expanded to 74 candidates
• Random selection from 18 candidates

[rustbot]

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[jieyouxu]

Thanks
@bors r+ rollup

View changes since this review

[jieyouxu]

Remark: we could consider default setting edition but allow overriding, but explicit is fine

[rust-bors]

📌 Commit a1d6de2 has been approved by jieyouxu

It is now in the queue for this repository.

[jhpratt]

@bors r- #160481 (comment)

---- messages::deduplicate_errors stdout ----
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo test -j1`

thread 'messages::deduplicate_errors' (114996) panicked at src/tools/cargo/tests/testsuite/messages.rs:163:10:

--- Expected
++++ actual:   stderr
   1    1 | [COMPILING] foo v0.0.1 ([ROOT]/foo)
   2      - [NOTE] `--edition` is unspecified, defaulting to `2015` while the latest is `2024`; it must be one of: <2015|2018|2021|2024|future>
   3      - 
   4    2 | [ERROR] expected one of `!` or `::`, found `should`
   5    3 |  --> src/lib.rs:2:22
   6    4 |   |
   7    5 | 2 |                 this should not compile
   8    6 |   |                      ^^^^^^ expected one of `!` or `::`
   9    7 | 
  10    8 | [ERROR] could not compile `foo` (lib) due to 1 previous error



---- messages::deduplicate_errors stdout end ----
---- messages::deduplicate_messages_basic stdout ----
running `/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-tools/x86_64-unknown-linux-gnu/release/cargo test --no-run -j1`

thread 'messages::deduplicate_messages_basic' (115030) panicked at src/tools/cargo/tests/testsuite/messages.rs:87:10:

--- Expected
++++ actual:   stderr
   1    1 | [COMPILING] foo v0.0.1 ([ROOT]/foo)
   2      - [NOTE] `--edition` is unspecified, defaulting to `2015` while the latest is `2024`; it must be one of: <2015|2018|2021|2024|future>
   3      - 
   4    2 | [WARNING] unused variable: `x`
   5    3 |  --> src/lib.rs:3:25
   6    4 |   |
   7    5 | 3 |                     let x = 1;
   8    6 |   |                         ^ [HELP] if this is intentional, prefix it with an underscore: `_x`
   9    7 |   |
  10    8 |   = [NOTE] `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default
  11    9 | 
  12      - [WARNING] `foo` (lib) generated 1 warning[..]
       10 + [WARNING] `foo` (lib) generated 1 warning (run `cargo fix --lib -p foo` to apply 1 suggestion)
  13   11 | [WARNING] `foo` (lib test) generated 1 warning (1 duplicate)
  14   12 | [FINISHED] `test` profile [unoptimized + debuginfo] target(s) in [ELAPSED]s
  15      - [EXECUTABLE] unittests src/lib.rs (target/debug/deps/foo-[HASH][EXE])
       13 + [EXECUTABLE] unittests src/lib.rs (target/debug/deps/foo-[HASH])



---- messages::deduplicate_messages_basic stdout end ----

[rust-bors]

This pull request was unapproved.

This PR was contained in a rollup (#160481), which was unapproved.

View changes since this unapproval