Repository navigation
Fix wildcard_imports infinite loop on macro generated glob imports - #17828
Merged
Merged
Conversation
rustbot
added
S-waiting-on-community-reviews
Collaborator
|
Thanks for the pull request. A reviewer will take a look after it receives 2 community reviews. In the meantime, we would highly appreciate if you could try to review any of PRs waiting on community reviews. |
CommanderStorm
approved these changes
Oct 1, 2026
schneems
suggested changes
Oct 2, 2026
There was a problem hiding this comment.
Community review: Does what it says on the tin, good work. Thanks!
There's an unhandled edgecase (found using an LLM to understand the code/codebase chat logs, that I manually validated/verified).
- Requested: Add that test case for source code with a
*in it after the macro call and fix.
The other comments are personal preference/style, feel free to dismiss them.
- Optional(pedantic/bikeshed/naming) variable naming: Update
span->extended->with_starvariables tospan->span_until_glob->span_with_glob. - Optional(pedantic/bikeshed/code-style) functional style: Get rid of intermediate variables by switching to a function style.
Gri-ffin
force-pushed
the
issues/17799
branch
3 times, most recently
from
October 3, 2026 16:44
c02300a to
2fab9d6
Compare
schneems
approved these changes
Oct 3, 2026
rustbot
removed
the
S-waiting-on-community-reviews
Collaborator
|
r? @llogiq rustbot has assigned @llogiq for the project review. Use Why was this reviewer chosen?The reviewer was selected based on:
|
dswij
added this pull request to the merge queue
Oct 19, 2026
rustbot
removed
the
S-waiting-on-review
CommanderStorm
added
the
beta-nominated
Member
flip1995
added
beta-accepted
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17799
changelog: [
wildcard_imports]: fix infinite loop on macro generated glob imports