Repository navigation
Don't suggest Box::leak in nonnull_unchecked_on_box_ptr - #17752
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
Jarcho
added
the
beta-nominated
Contributor
Author
|
cc @RalfJung |
|
Lintcheck changes for 26ae304
This comment will be updated if you push new changes |
CommanderStorm
approved these changes
Sep 17, 2026
|
|
||
| #[clippy::msrv = "1.25"] | ||
| #[clippy::msrv = "1.98"] | ||
| fn msrv_1_25() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fn msrv_1_25() { | |
| fn msrv_1_98() { |
|
|
||
| #[clippy::msrv = "1.89"] | ||
| #[clippy::msrv = "1.99"] | ||
| fn msrv_1_89() { |
Contributor
There was a problem hiding this comment.
Suggested change
| fn msrv_1_89() { | |
| fn msrv_1_99() { |
notriddle
approved these changes
Sep 18, 2026
Contributor
There was a problem hiding this comment.
Community review: this looks fine to me (except #17752 (comment))
…ing isn't well defined.
flip1995
approved these changes
Sep 24, 2026
Member
|
@rustbot merge |
rustbot
added this pull request to the merge queue
Sep 24, 2026
Member
|
I will backport this to the current beta today. But I won't also sync it to master. Instead I will backport #17485 to beta in the next cycle. |
rustbot
removed
the
S-waiting-on-review
Member
flip1995
added
beta-accepted
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 25, 2026
[beta] Clippy backport r? Mark-Simulacrum Backporting 3 PRs: - rust-lang/rust-clippy#17632 fixes a UX issue where `--explain` stopped working in the current beta - rust-lang/rust-clippy#17752 Fixes a bad suggestion that this lint is currently making on stable -- we'd rather fix this sooner than later - rust-lang/rust-clippy#17731 Fixes an infinite loop
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Sep 26, 2026
[beta] Clippy backport r? Mark-Simulacrum Backporting 3 PRs: - rust-lang/rust-clippy#17632 fixes a UX issue where `--explain` stopped working in the current beta - rust-lang/rust-clippy#17752 Fixes a bad suggestion that this lint is currently making on stable -- we'd rather fix this sooner than later - rust-lang/rust-clippy#17731 Fixes an infinite loop
Member
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
rust-bors Bot
pushed a commit
to rust-lang/rust
that referenced
this pull request
Nov 5, 2026
[beta] backports Cherry picked: * #165497 * #165499 - rust-lang/rust-clippy#17752 (was already last beta, but we didn't manage to get the proper fixed merged in time like we planned) - rust-lang/rust-clippy#17828 - rust-lang/rust-clippy#17941 r? @ghost
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements part of #17485
Unleaking a leaked
Boxpointer isn't well defined, so we shouldn't be suggesting to changeinto_rawintoleak. This needs to be backported to beta and ideally would be synced before a new beta is branched off.r? flip1995
changelog: [
nonnull_unchecked_on_box_ptr]: Don't suggestBox::leak