refactor(bindgen): remove the dependency on itertools - #3408
Merged
Conversation
AudaciousAxiom
commented
Jul 28, 2026
| fields.extend(non_bitfields); | ||
| let raw_fields = raw_fields.by_ref(); | ||
| while let Some(raw_field) = | ||
| raw_fields.next_if(|f| f.bitfield_width().is_none()) |
Contributor
Author
There was a problem hiding this comment.
This uses Peekable::next_if(), which wasn't available when this was written, but has been stable since 1.51.
| @@ -496,22 +494,27 @@ where | |||
| // resulting fields. We introduce a scope here so that we can use | |||
| // `raw_fields` again after the `by_ref` iterator adaptor is dropped. | |||
| { | |||
Contributor
Author
There was a problem hiding this comment.
This preserves the original additional scope even though I'm not sure it's actually needed: the tests pass just the same without it (and with a single .by_ref() call). Happy to remove it if it is indeed extraneous.
Contributor
There was a problem hiding this comment.
The by_ref is overall redundant. I opened #3410 for this.
AudaciousAxiom
marked this pull request as ready for review
July 28, 2026 09:02
Contributor
Author
|
r? @emilio |
AudaciousAxiom
commented
Jul 28, 2026
| while let Some(raw_field) = | ||
| raw_fields.next_if(|f| f.bitfield_width().is_some()) | ||
| { | ||
| bitfields.push(raw_field); |
Contributor
Author
There was a problem hiding this comment.
This allocates all the bitfields at once instead of using an iterator: I expect there is relatively few of them, so I hope this is acceptable.
|
Also closes #3086 |
emilio
approved these changes
Jul 28, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This proposes to slightly refactor the only use of
itertoolsto be able to remove the dependency on it. Removing the dependency helps reduce the future maintenance burden (e.g., see #3407).Closes #3407