Skip to content

feat: add all_types that exposes implicit type parameters from GenericSubstitution #23398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChayimFriedman2 merged 1 commit into from
Sep 22, 2026
Merged

feat: add all_types that exposes implicit type parameters from GenericSubstitution #23398

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions crates/hir/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3141,7 +3141,10 @@ impl<'db> GenericSubstitution<'db> {
}
}

pub fn types(&self, db: &'db dyn HirDatabase) -> Vec<(Symbol, Type<'db>)> {
fn types_impl(
&self,
db: &'db dyn HirDatabase,
) -> impl Iterator<Item = (Ty<'db>, Option<Name>)> {
let container = match self.def {
GenericDefId::ConstId(id) => Some(id.lookup(db).container),
GenericDefId::FunctionId(id) => Some(id.lookup(db).container),
Expand All @@ -3168,9 +3171,12 @@ impl<'db> GenericSubstitution<'db> {
TypeOrConstParamData::TypeParamData(param) => Some(param.name.clone()),
TypeOrConstParamData::ConstParamData(_) => None,
});
self.subst
.types()
.zip(container_type_params.into_iter().flatten().chain(type_params))
self.subst.types().zip(container_type_params.into_iter().flatten().chain(type_params))
}

/// Returns type arguments with type parameter names.
pub fn types(&self, db: &'db dyn HirDatabase) -> Vec<(Symbol, Type<'db>)> {
self.types_impl(db)
.filter_map(|(ty, name)| {
Some((
name?.symbol().clone(),
Expand All @@ -3179,6 +3185,18 @@ impl<'db> GenericSubstitution<'db> {
})
.collect()
}

/// Returns all type arguments, including unnamed ones such as implicit `impl Trait` parameters.
///
/// Unlike [`Self::types`], this does not filter out arguments that have no
/// corresponding type parameter name.
// Note: this method is not used by rust-analyzer itself as of writing, but is
// used by external tools, so please do not remove it even if it appears unused.
pub fn all_types(&self, db: &'db dyn HirDatabase) -> Vec<Type<'db>> {
self.types_impl(db)
.map(|(ty, _)| Type { ty: EarlyBinder::bind(ty), owner: self.owner })
.collect()
}
}

/// A single local definition.
Expand Down
Loading