Repository navigation
Don't fail extension activation when the server fails to start. - #23386
Merged
Merged
Conversation
rustbot
added
the
S-waiting-on-review
michaelgruenewald
force-pushed
the
push-lpktqwoxnytr
branch
from
September 17, 2026 20:43
4ef5017 to
71c16e4
Compare
ChayimFriedman2
approved these changes
Sep 24, 2026
rustbot
removed
the
S-waiting-on-review
BenjaminBrienen
added a commit
to BenjaminBrienen/wgsl-analyzer
that referenced
this pull request
Sep 29, 2026
github-merge-queue Bot
pushed a commit
to wgsl-analyzer/wgsl-analyzer
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of failing extension activation when the server fails to start initially, set the server health to
stoppedand continue. This results in the same behavior as if the server crashed later.Tested that changing the config, etc. still correctly restarts the server and that manually restarting it also works.
fixes #23371