Skip to content

fix: hover show impl header when impl with trait - #23365

Open
A4-Tacks wants to merge 1 commit into
rust-lang:masterfrom
A4-Tacks:hover-always-container
Open

A4-Tacks wants to merge 1 commit into
rust-lang:masterfrom
A4-Tacks:hover-always-container

Conversation

@A4-Tacks

Copy link
Copy Markdown
Member

Example

trait Trait { fn method(); }
impl Trait for Foo { fn method() {} }
struct Foo;

fn main() {
    Foo::$0method()
}

Before this PR

fn method()

After this PR

impl Trait for Foo
fn method()

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 15, 2026
Example
---
```rust
trait Trait { fn method(); }
impl Trait for Foo { fn method() {} }
struct Foo;

fn main() {
    Foo::$0method()
}
```

**Before this PR**

```rust
fn method()
```

**After this PR**

```rust
impl Trait for Foo
fn method()
```
@A4-Tacks
A4-Tacks force-pushed the hover-always-container branch from 28c0880 to 4cfdc45 Compare September 15, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants