Skip to content

Trivia in tokens - #23276

Open
bit-aloo wants to merge 30 commits into
rust-lang:masterfrom
bit-aloo:2026-08-29-trivia-in-tokens
Open

bit-aloo wants to merge 30 commits into
rust-lang:masterfrom
bit-aloo:2026-08-29-trivia-in-tokens

Conversation

@bit-aloo

@bit-aloo bit-aloo commented Sep 1, 2026

Copy link
Copy Markdown
Member

TODO

@ChayimFriedman2

Copy link
Copy Markdown
Contributor

+18,204 -23,157

😢

Isn't there a way to make this smaller? Some ideas:

  • Do not print [] [] for empty leading+trailing trivia.
  • Print leading/trailing trivia like before temporarily.

@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch 2 times, most recently from 20ae132 to 138f614 Compare September 11, 2026 08:06
@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from 26b762b to 612f015 Compare September 11, 2026 08:44
@bit-aloo
bit-aloo marked this pull request as ready for review September 11, 2026 09:24
@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 11, 2026
@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from 73cb0d5 to a2547b1 Compare September 14, 2026 10:44
@rustbot

This comment has been minimized.

@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from a2547b1 to ac2821d Compare September 23, 2026 08:15
@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from ac2821d to b005976 Compare September 23, 2026 09:06
@rustbot

This comment has been minimized.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from 501faae to ac4c2d7 Compare September 27, 2026 01:26
@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from ac4c2d7 to edf64cb Compare September 27, 2026 13:00
@rustbot

rustbot commented Sep 27, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

@bit-aloo
bit-aloo force-pushed the 2026-08-29-trivia-in-tokens branch from edf64cb to abc9483 Compare September 27, 2026 13:14
@rustbot

rustbot commented Oct 5, 2026

Copy link
Copy Markdown
Collaborator

☔ The latest upstream changes (possibly #23467) made this pull request unmergeable. Please resolve the merge conflicts.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants