S390X stabilize backchain - #2317
Open
fneddy wants to merge 1 commit into
Open
Conversation
Document the s390x `backchain` target feature Stabilized in rust-lang/rust#158612
rustbot
added
the
S-waiting-on-review
7 tasks
ehuss
added
the
S-waiting-on-stabilization
| `miscellaneous-extensions-2` | | miscellaneous extensions 2 | ||
| `miscellaneous-extensions-3` | | miscellaneous extensions 3 | ||
| `miscellaneous-extensions-4` | | miscellaneous extensions 4 | ||
| `backchain` | | store the caller's frame address in the callee's stack frame backchain slot |
Contributor
There was a problem hiding this comment.
a quick PDF search of the [z/Architecture Principles of Operation] PDF doesn't have any hits for "backchain" - is there some other documentation that might be worth linking to?
Author
There was a problem hiding this comment.
oh yes the PoP does only describe the ISA. the ABI is described here: https://ibm.github.io/s390x-abi/ and i think due to "historic reasons" its called "back chain"(with a space). Should I add a reference to the md?
Contributor
There was a problem hiding this comment.
I would suggest yes (and maybe with a note that it has a space in that document)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Document the s390x
backchaintarget featureStabilized in rust-lang/rust#158612