Document import_trait_associated_functions feature - #2312
Open
camsteffen wants to merge 1 commit into
Open
Conversation
rustbot
added
the
S-waiting-on-review
ehuss
added
the
S-waiting-on-stabilization
|
|
||
| r[items.use.path.disallowed] | ||
| They cannot import [associated items], [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. | ||
| They cannot import associated items of structs or enums, [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. |
Contributor
There was a problem hiding this comment.
also not from unions, right?
maybe instead
Suggested change
| They cannot import associated items of structs or enums, [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. | |
| They cannot import associated items (other than associated items of traits), [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. |
so that if some other thing with associated items is added later we don't need to update the list here again?
Author
There was a problem hiding this comment.
Good catch. I think we may as well list them out. But the sentence structure gets pretty unwieldy so we could split it into two sentences.
Suggested change
| They cannot import associated items of structs or enums, [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. | |
| They cannot import associated items of structs, enums or unions. They cannot import [generic parameters], [local variables], paths with [`Self`], or [tool attributes]. More restrictions are described below. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tracking issue