Add wasm support to bitreq#656
Open
tankyleo wants to merge 1 commit into
Open
Conversation
Co-Authored-By: HAL 9000
tankyleo
requested review from
TheBlueMatt,
oleonardolima,
tcharding and
tnull
as code owners
July 9, 2026 15:10
TheBlueMatt
reviewed
Jul 17, 2026
| Ok(bytes) | ||
| } | ||
|
|
||
| pub(crate) async fn send(request: ParsedRequest) -> Result<Response, Error> { |
Member
There was a problem hiding this comment.
It would be nice if, rather than relying explicitly on js_sys, the cfg flag enables someone to set some global handlers that can be configured to point to js_sys but also can be configured as required (eg for those doing wasm without wasm_bindgen).
TheBlueMatt
reviewed
Jul 17, 2026
|
|
||
| log = { version = "0.4.0", default-features = false, optional = true } | ||
| [target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies] | ||
| js-sys = { version = "0.3", default-features = false } |
Member
There was a problem hiding this comment.
meh, can we just feature-gate this? Not everything wasm is necessarily wasm_bindgen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-Authored-By: HAL 9000