Repository navigation
fix(apps): bind volume mounts from RUNPOD_MOUNTS when the runtime did not - #626
Open
justinwlin wants to merge 3 commits into
Open
justinwlin wants to merge 3 commits into
justinwlin wants to merge 3 commits into
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
This was referenced Oct 19, 2026
… not vol.path reads bindings the worker runtime installs through _configure_mounts before user code. Runtime images published before that hook never call it, so on them every deployed NetworkVolume attached but vol.path raised "not mounted in the current execution". Deployed workers run the client's vendored runpod package, so the first vol.path lookup now installs the bindings from the RUNPOD_MOUNTS provisioning env itself when the runtime has not. A runtime that configured mounts still takes precedence.
justinwlin
force-pushed
the
fix/volume-path-self-configure
branch
from
October 20, 2026 15:48
317e3fd to
dee2d20
Compare
justinwlin
marked this pull request as ready for review
October 20, 2026 15:48
|
|
||
| import pytest | ||
|
|
||
| import runpod.apps.volume as volume_mod |
|
|
||
| import pytest | ||
|
|
||
| import runpod.apps.volume as volume_mod |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flash → SDK 2.0 fix stack
PRs 1–9 are independent PRs off
main, and 10 is stacked on 9. Merge in this order. Hover a link for its status.mainpeft/accelerategets bundledrp flash devleaks endpoints when stopped by a signalvol.pathsays "not mounted" on deployed workersrunpod2.0.0rc2 with 1–6In deployed apps,
NetworkVolume.pathraisedvolume '...' is not mounted in the current executioneven though the volume was attached at/runpod-volume.Cause
vol.pathreads bindings that the worker runtime installs by calling_configure_mountsbefore user code (sdk-runtimemounts.py, added 2026-09-29). The published runtime images (runpod/queue:py3.12-latestand the rest) were pushed on 2026-09-22 and don't contain that hook.docker runagainst the image shows nomounts.py, and itsqueue/worker.pynever callsconfigure_mounts. The bindings are never installed.Change
Deployed workers run the client's vendored
runpod(unlessRUNPOD_PACKAGE_SPECoverrides the package), so the firstvol.pathlookup now installs the bindings from theRUNPOD_MOUNTSprovisioning env itself when the runtime hasn't. A runtime that configured mounts still takes precedence. Invalid JSON raisesVolumeError.This removes the SDK's dependence on the image for
vol.path. The images still need a rebuild for dev sessions, which run on the image's ownrunpod.Testing
vol.path / "probe.txt"mainVolumeError: volume '...' is not mounted in the current executionvol.path; apps used the literal/runpod-volume{'path': '/runpod-volume', 'read': 'ok'}How we tested and compared
docker run runpod/queue:py3.12-latestshows nomounts.py, and itsqueue/worker.pynever callsconfigure_mounts. The images predate the hook.main(raised the error above) and from this branch (returned the path). The app and volume were deleted afterward.RUNPOD_MOUNTSwhen the runtime did not, the runtime's configuration winning, and invalid JSON.pytest tests: 1482 passed, coverage 91.66%.Review (Codex, two rounds)
runpod" has an exception:RUNPOD_PACKAGE_SPECskips the overlay