Add app exclusions management to Settings - #9
Open
OleksandrAWS wants to merge 1 commit into
Open
Conversation
Settings previously had no way to view or manage the correction blacklist beyond the "Enable/Disable in Current App" menu-bar item, which only affected the frontmost app. - Add an "Excluded Apps" list to SettingsView backed by AppFilter, with icons/names resolved via NSWorkspace and remove via a minus button (multi-select supported). - Add app via a menu: pick from currently running apps (a sheet listing NSWorkspace.shared.runningApplications, excluding apps already excluded and SwitchFix itself), or browse the filesystem via NSOpenPanel (defaults to /Applications, but any folder works). - Resize the Settings window to fit the new section.
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AppFilterblacklist (previously only manageable one-at-a-time via the "Enable/Disable in Current App" menu-bar item).+menu with two sources:NSWorkspace.shared.runningApplications, regular apps only, excludes already-excluded apps and SwitchFix itself).NSOpenPaneldefaulting to/Applications, but browsable to any folder.-button with multi-select support.Why
Users had no way to see or manage the full exclusion list, and could only toggle the currently frontmost app from the menu bar.
Test plan
swift buildsucceeds