Move markdown-it types for options export - #56
Merged
Conversation
Owner
|
Thanks. I will probably update all dependencies (including typescript 7) and make a release later this week |
Owner
|
Released: v6.0.1. Thanks for your help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
First, thanks so much for creating markdown-it-math.
Second: I was just updating a project of mine to using typescript 7 and
MarkdownItandTokengot flagged as unresolved in the dependency lib check.You can repro the error in markdown-it-math itself if you update to typescript@7, but I didn't do that here in case you aren't ready for the switch (and to be sure the change still works with typescript 6). Happy to add it to the PR if that's helpful though.
It's interesting that typescript 6 doesn't seem to be bothered by them being
anyin options.js (though they are properly typed in plugin.js), but typescript 7's jsdoc checking is a bit stricter, so something shifted. Looking at the code, it looks like this change may have been what you intended anyways, but the two typedefs didn't move tooptions.jswhen the@callbackdeclaration moved there.Thanks again!