chore: disable on-demand asset compilation and normalize Gemfile.lock platforms (#7040)#7071
Open
augustocbx wants to merge 1 commit into
Open
Conversation
augustocbx
requested review from
FireLemons,
compwron and
elasticspoon
as code owners
July 18, 2026 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What github issue is this PR for, if any?
Addresses the two High priority (real impact) items of #7040. The remaining medium/low-priority checklist items (npm audit, Ruby patch bump, deprecated packages, install-script allowlist) are left as follow-ups, so this does not close the issue.
What changed, and why?
Two deploy-log hardening items from #7040:
Disabled on-demand asset compilation in production. The
casa-qabuild log warns thatconfig.assets.compile = truein production. Assets are already precompiled at build time (rake assets:precompileruns during the build), so on-demand compilation only adds per-request latency and load — and it silently masks a missing precompiled asset instead of failing fast. Setconfig.assets.compile = falseinconfig/environments/production.rb, which is the standard Rails production default for a precompiled app.Normalized
Gemfile.lockplatforms. The build warns that the platform-specificffi-1.17.2gem is installed while the lockfile only carried OS-version-pinned platforms. Ranbundle lock --normalize-platforms, which collapses the version-pinned entries (arm64-darwin-21/22,x86_64-darwin-21/23) to their generic forms (arm64-darwin,x86_64-darwin). Therubyandx86_64-linux(Heroku) platforms are retained and the platform-specific gem specs are unchanged.bundle checkpasses after the change.How is this tested? (please write rspec and jest tests!) 💖💪
These are production config / lockfile changes with no application-behavior surface, so there is no meaningful RSpec/Jest test to add (the test environment does not load
config/environments/production.rb, and there is no existing convention in this repo for asserting environment config). Verification instead:ruby -c config/environments/production.rb→Syntax OK.bundle exec standardrb config/environments/production.rb→ exit 0, no offenses.bundle lock --normalize-platformsproduced a minimal diff touching only thePLATFORMSblock (2 insertions, 4 deletions);bundle check→ "The Gemfile's dependencies are satisfied".rake assets:precompilesuccessfully, socompile = falsehas all referenced assets available.Screenshots please :)
Not applicable — no user-facing UI change (production configuration and dependency lockfile only).