Prevent double proposal submission from a double-clicked submit button#1135
Merged
amatsuda merged 1 commit intoJul 11, 2026
Merged
Conversation
This app disables Turbo Drive globally (opt-in), so the proposal form submits as a plain full-page POST with no double-submit protection — Turbo's submitter disabling never engages and rails-ujs disable_with is no longer bundled. A double click during a slow response POSTed twice and created duplicate proposals. Add a small generic disable-submit Stimulus controller that disables the form's submit buttons on the next tick after the submit event (so the form data set, including a named submitter, is built first), and wire it to the proposal new/edit forms. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This app disables Turbo Drive globally (opt-in), so the proposal form submits as a plain full-page POST with no double-submit protection — Turbo's submitter disabling never engages and rails-ujs disable_with is no longer bundled. A double click during a slow response POSTed twice and created duplicate proposals.
Add a small generic disable-submit Stimulus controller that disables the form's submit buttons on the next tick after the submit event (so the form data set, including a named submitter, is built first), and wire it to the proposal new/edit forms.