Bump loader-utils to 2.0.3+ (transitive) to fix critical prototype pollution alert#88
Open
technicalpickles wants to merge 1 commit into
Open
Bump loader-utils to 2.0.3+ (transitive) to fix critical prototype pollution alert#88technicalpickles wants to merge 1 commit into
technicalpickles wants to merge 1 commit into
Conversation
…j-7488) loader-utils@2.0.2 was hoisted transitively through six react-scripts loaders (react-refresh-webpack-plugin, @svgr/webpack, babel-loader, file-loader, resolve-url-loader, adjust-sourcemap-loader), all pinned to ^2.0.0. Rather than add a direct dependency to break the vulnerable range, this uses yarn resolutions scoped to those six requester paths so the hoisted instance resolves to 2.0.4. react-dev-utils's separate loader-utils@3.2.0 (not in the vulnerable range) is untouched. Fixes: https://github.com/rubyatscale/visualize_packs/security/dependabot/3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Dependabot alert #3 (critical):
loader-utilsprototype pollution, vulnerable range>=2.0.0 <2.0.3.loader-utils@2.0.2lives ind3_graph_generator/yarn.lockand is purely transitive, hoisted through six react-scripts-bundled loaders (react-refresh-webpack-plugin,@svgr/webpack,babel-loader,file-loader,resolve-url-loader,adjust-sourcemap-loader), all of which request^2.0.0.Rather than add a direct dependency to break the vulnerable range, this uses yarn's
resolutionsfield, scoped to those six requester paths, to force the hoisted instance up to 2.0.4. There's a separate, unrelatedloader-utils@3.2.0resolved forreact-dev-utils(outside the vulnerable range) that this deliberately leaves alone, a bare"loader-utils"resolution key would have collapsed both instances into one and silently downgraded that unrelated 3.x install.Verification
yarn why loader-utilsbefore:yarn why loader-utilsafter:git difftouches onlyd3_graph_generator/package.json(theresolutionsaddition) andd3_graph_generator/yarn.lock.This repo's CI (
ci.yml) doesn't build or test thed3_graph_generatorsubproject at all, it's a standalone dev tool invoked manually viayarn start. I ranyarn buildlocally to sanity check and it fails on both this branch andmainwith an unrelated pre-existing error (@babel/helper-compilation-targets: 'opera_mobile' is not a valid target), a stalecaniuse-lite/browserslist issue in this old CRA setup, unrelated to loader-utils and out of scope here.Test plan
yarn why loader-utilsconfirms hoisted instance is now 2.0.4, all six requesters satisfiedreact-dev-utilsloader-utils@3.2.0block is untouched in the lockfile diffyarn buildfailure is pre-existing onmain(unrelated to this change)