Repository navigation
Upgrade chai to 6 and type packages, remove unused sinon - #33
Merged
Merged
Conversation
- chai 4 -> 6, with @types/chai 5. chai 5+ is ESM-only; the compiled CommonJS tests load it through require(esm), which the Node 24 extension host in current VS Code supports. - @types/node 22 -> 24, matching the Node version in the VS Code extension host (Electron 43, Node 24.21, as of VS Code 1.140). Dependabot proposed 26, which would type APIs the runtime lacks. - @types/vscode 1.115 -> 1.138 in the lockfile. The ^1.32.0 range is kept: vsce refuses to package when the @types/vscode range exceeds engines.vscode. - Remove sinon and @types/sinon. No test imports sinon, and dropping it removes one of the two dependency paths to diff 7.0.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Covers the rest of the grouped Dependabot PR #28, following #29 and #31. No source changes; only
package.jsonandyarn.lock.Changes
chai@types/chai@types/node@types/vscode^1.32.0sinon,@types/sinonrequire(esm). The tests run inside VS Code's extension host, which in VS Code 1.140 is Electron 43 with Node 24.21 and supports this. With one assertion deliberately broken, the run reportedAssertionError: expected true to be falseand exited 1, so chai 6 failures still fail CI.@types/node24, not 26: extension code runs on the extension host's Node 24. Types for 26 would let code compile against APIs that don't exist at runtime.@types/vscoderange kept at^1.32.0:vsce packagerefuses to build when the@types/vscoderange is higher thanengines.vscode. So only the lockfile moves, as in Bump the npm group with 11 updates #28.vsce packagestill succeeds.diff7.0.0 advisory (auto-dismissed as #40). The remaining path is through mocha, via@vscode/test-cli.Testing
yarn install --frozen-lockfile,yarn run vscode:prepublishandyarn lintpass. All 13 tests pass locally.vsce packagebuilds successfully.yarn auditshows 1 low-severity advisory, down from 2.Worth deciding separately
engines.vscodeis still^1.32.0, but the type packages now describe VS Code 1.138 and Node 24. The compiler won't catch use of an API that older VS Code versions lack. This was already true with 1.115, but the gap is wider now. Raisingengines.vscodewould close it, at the cost of dropping support for older VS Code versions.