Print a release notes link instead of the whole changelog on gem update --system - #9794
Open
hsbt wants to merge 3 commits into
Open
Print a release notes link instead of the whole changelog on gem update --system#9794hsbt wants to merge 3 commits into
gem update --system#9794hsbt wants to merge 3 commits into
Conversation
…ystem CHANGELOG.md is over 7,000 lines of generated PR titles, and printing every entry since the previous version dominates the output (478 of 499 lines on the ruby:3.4 image). Print a single link to the versioned CHANGELOG.md instead, keeping --previous-version so the message can name the range to read. Fixes #9789 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
With the changelog dump removed from gem update --system, the update suggestion is where users decide whether to update, so link the release notes for the latest version there. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Use the same versioned CHANGELOG.md link as setup so the notice covers the cumulative changes since the installed version, not just the latest release. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Member
Author
|
@kenchan How about this? |
|
Thanks, this is exactly what I had in mind — really glad to see it. I went through it with Claude Code and found two cases where the new message isn't accurate. Both only affect
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gem update --systemprints everyCHANGELOG.mdentry newer than the previous version, which is 478 of the 499 output lines on theruby:3.4Docker image. The changelog is generated from merged PR titles, so what gets printed is closer to a PR list than release notes. This replaces the dump with a single line linking the versionedCHANGELOG.md.setup.rbkeeps accepting--previous-versionso the message can name the range to read. The changelog is printed by the new version'ssetup.rbchild process, so this also takes effect when upgrading from older RubyGems.With this change,
gem update --systemprints the link where the changelog dump used to be:The update suggestion shown before updating gets the same link and now matches npm's three-line notice:
Fixes #9789