Repository navigation
Conversation
require "rss" loaded the feed generators along with the parsers. Apps that only parse feeds now skip rss/maker: about 97k allocated objects, 24k retained objects and 5 MB RSS less per process.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
require "rss"loads the feed generators along with the parsers, so an app that only parses feeds pays forrss/makertoo: about 97k allocated objects, 24k retained objects, 5.3 MB of RSS and 33 ms per process on Ruby 4.0.7, on top of the 127k objects and 11 MB of the parsers.This autoloads
RSS::Makerinstead of requiring it.RSS::Maker.makeand#to_feedload it on first use, and every other filerequire "rss"loaded is still loaded.On our app, a Rails e-commerce site that only reads feeds to display them, this is 5 MB less in every process.
test/test-autoload.rbchecks in a subprocess thatrequire "rss"doesn't loadrss/makerand that referencingRSS::Makerdoes: it fails without the change. The suite passes, 322 tests.🤖 Generated with Claude Code, but prompted, read, and verified by @czj, a caring human :)