Repository navigation
🐛 Fix SequenceSet#slice when starting at "*" - #772
Merged
Merged
Conversation
nevans
force-pushed
the
sequence_set/fix-slice-when-start-at-star
branch
from
October 3, 2026 00:28
a8cb744 to
bb3a8f9
Compare
nevans
changed the base branch from
sequence_set/slice-rdoc
to
sequence_set/slice-refactoring
October 3, 2026 00:32
nevans
added this pull request to stack #775
October 3, 2026 00:32
nevans
added
bug
nevans
force-pushed
the
sequence_set/fix-slice-when-start-at-star
branch
from
October 3, 2026 13:42
bb3a8f9 to
37906b5
Compare
When the starting index points to "*", the `min <= max` comparison fails and an exception is raised. Without changing the basic `#slice_range` structure and algorithm, the simplest fix is to use the internal integers for `min` and `max`, which will always be comparable.
nevans
force-pushed
the
sequence_set/fix-slice-when-start-at-star
branch
from
October 10, 2026 03:15
37906b5 to
f9b6018
Compare
nevans
changed the title
SequenceSet#slice when starting at "*"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the starting index points to "*", the
min <= maxcomparison fails and an exception was raised.Without changing the basic
#slice_rangestructure and algorithm, the simplest fix is to use the internal integers forminandmax, which will always be comparable.