Repository navigation
Conversation
test: add coverage for SAVE_HISTORY=0 edge case
Author
|
Hi! I noticed that the build / rake test prism-latest check is failing. This seems unrelated to my changes (documentation updates and a history test), as those don't touch the parser code. Could you confirm if this is a pre-existing issue with the prism-latest test suite? Happy to investigate further if needed! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi! 👋 While exploring the codebase to prepare for GSoC 2027, I noticed a couple of small opportunities for improvement and wanted to contribute.
This PR includes two minor quality-of-life improvements:
SAVE_HISTORY = 0edge case. During testing, I discovered that0retains the existing history file without appending new commands, so this test locks in that behavior to prevent future regressions.All local tests pass. Thanks for your time and review!