Handle nil backtrace_locations in generate_snippet#80
Merged
Conversation
marcoroth
added a commit
to rubyevents/rubyevents
that referenced
this pull request
Jul 8, 2026
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a crash in
ErrorHighlight::CoreExt#generate_snippetwhen an exception has abacktracebut nobacktrace_locations.Exception#backtrace_locationscan benileven whenbacktraceis set, most commonly when an exception is rebuilt viaMarshalorset_backtrace.A real-world case: the parallel gem marshals exceptions from forked workers back to the parent process, where
backtracesurvives as strings butbacktrace_locationsisnil.When an
ArgumentErrormessage matches one of the keyword-argument patterns (wrong number of arguments,unknown keyword, …),generate_snippetcallslocs.sizewithout checking fornilfirst. Displaying such an exception then raises:Since this fires inside
detailed_message, it masks the original exception entirely, e.g. Rake's error display crashes and the user never sees the real error (example CI failure):Repro:
This pull request adds the same nil guard
ErrorHighlight.spotalready uses inbase.rb, plus a regression test using the Marshal round-trip.