Skip to content

Redact structured debug bodies on 1.4 - #785

Merged
pboling merged 6 commits into
1-4-stablefrom
fix/1-4-debug-log-redaction
Oct 28, 2026
Merged

pboling merged 6 commits into
1-4-stablefrom
fix/1-4-debug-log-redaction

Conversation

@pboling

@pboling pboling commented Oct 28, 2026

Copy link
Copy Markdown
Member

Summary

  • Redact sensitive values in structured Hash and Array request/response bodies before Faraday formats them.
  • Disable body logging on Faraday 0.x, where structured redaction is unavailable.
  • Cover nested structures, pair arrays, serialized bodies, and query strings; link the fix to GHSA-cmh8-5q25-68v6.

Validation

  • K_SOUP_COV_MIN_HARD=false bundle exec kettle-test spec/oauth2/sanitized_log_formatter_spec.rb spec/oauth2/client_spec.rb (69 examples, 0 failures)
  • bundle exec rubocop-gradual (no new issues)

Copilot AI balanced review requested due to automatic review settings October 28, 2026 03:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@github-actions

Copy link
Copy Markdown

Coverage Report for CI Build 40628592216

Coverage decreased (-1.5%) to 93.909%

Details

  • Coverage decreased (-1.5%) from the base build.
  • Patch coverage: 6 uncovered changes across 1 file (52 of 58 lines covered, 89.66%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
lib/oauth2/sanitized_log_formatter.rb 54 48 88.89%
Total (2 files) 58 52 89.66%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 482
Covered Lines: 463
Line Coverage: 96.06%
Relevant Branches: 109
Covered Branches: 92
Branch Coverage: 84.4%
Branches in Coverage %: Yes
Coverage Strength: 31.1 hits per line

💛 - Coveralls

Copilot AI balanced review requested due to automatic review settings October 28, 2026 04:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@pboling
pboling merged commit 7b7d733 into 1-4-stable Oct 28, 2026
45 of 46 checks passed
@pboling
pboling deleted the fix/1-4-debug-log-redaction branch October 28, 2026 04:01
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Health
oauth2 96% 85% ➖
Summary 96% (467 / 486) 85% (94 / 111) ➖

Minimum allowed line rate is 92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants