Skip to content

test(vscode): harden startup-deadline E2E test against slow runners - #49

Merged
fi3ework merged 1 commit into
mainfrom
fix/e2e-deadline-flake
Sep 4, 2026
Merged

test(vscode): harden startup-deadline E2E test against slow runners#49
fi3ework merged 1 commit into
mainfrom
fix/e2e-deadline-flake

Conversation

@fi3ework

@fi3ework fi3ework commented Sep 4, 2026

Copy link
Copy Markdown
Member

Summary

  • Widen the never-settling startup-operation deadline from 50ms to 500ms so slow CI runners can invoke the operation before the deadline.
  • Match only the in-flight timeout message, preventing an already-expired deadline from satisfying the assertion.
  • Document the targeted divergence from the upstream-ported test inline and in the VS Code extension agent guidance.

Root cause

On a stalled Windows runner, more than 50ms could elapse between constructing the absolute deadline and runBeforeDeadline recomputing the remaining time. The helper then rejected through its already-expired path without invoking the operation. The previous regex accepted both timeout paths, so the test failed later at the attempts === 1 assertion instead of identifying the wrong rejection path.

Verification

  • pnpm lint && pnpm test:unit — passed (165 linted files; 31 test files and 264 tests passed)
  • VSCODE_CLI=1 pnpm test:e2e lint — passed (15/15 lint E2E suite launches exited successfully)

Related Links

Checklist

  • Tests updated.
  • Documentation updated.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 4, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-04T03:27:37.230410Z 5082da3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@fi3ework
fi3ework enabled auto-merge (squash) September 4, 2026 03:31
@fi3ework
fi3ework merged commit 6545c61 into main Sep 4, 2026
3 checks passed
@fi3ework
fi3ework deleted the fix/e2e-deadline-flake branch September 4, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant