feat(vscode)!: remove the rstack.enable master switch - #45
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
fi3ework
force-pushed
the
chore/remove-master-enable
branch
from
September 3, 2026 11:51
aaa899d to
08d5a12
Compare
Per-stack switches remain available for each tool integration. Users can disable the VS Code extension when they need to turn off every integration.
fi3ework
force-pushed
the
chore/remove-master-enable
branch
from
September 3, 2026 11:52
08d5a12 to
2ba37c2
Compare
fi3ework
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rstack.enablemanifest setting, shell gate, restart trigger, tests, and documentation.rstack.rslint.enable,rstack.rstest.enable, andrstack.fmt.enableas the per-stack kill switches.The master switch duplicated both the per-stack controls and VS Code's built-in extension control. This is intentionally a breaking settings change: the extension is pre-1.0, and
packages/vscode/AGENTS.mdexplicitly allows breaking changes without a deprecation or compatibility path.Related Links
N/A
Checklist
Testing
pnpm lint— exit 0:Found 0 lint errors, 0 type errors and 0 warnings (linted 161 files with 22 rules, type-checked 152 files in 335ms using 14 threads).pnpm test:unit— exit 0: 31 test files passed and 260 tests passed.pnpm --filter rstack build— exit 0; the extension, test worker, and lint worker bundles built successfully.VSCODE_CLI=1 pnpm test:e2e smoke— exit 0; the project-resolved plugin lint host produced the expectedlocal/no-nulldiagnostic.