Repository navigation
fix: scope Rsbuild package discovery to publishable packages - #111
Merged
Merged
Conversation
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing Rsbuild's root
workspacesfield in web-infra-dev/rsbuild#8701 makes workspace discovery include E2E fixtures. Unnamed fixtures fail validation before Eco-CI can filter them; named, non-private fixtures would also leak into overrides. This blocked all eight Rsbuild suites in run 39386570110.Add a shared per-stack package-directory configuration and discover Rsbuild's direct
packages/*manifests before validation, matching its release scope. Keep private packages excluded and reject invalid public manifests. Only Rsbuild opts in because its release scope and old/new package sets were verified; other stacks retain existing discovery. No new dependencies.Validation:
pnpm checkandgit diff --check: passed.fb56520d: the original missing-name error reproduces, and the fix returns exactly the same 12 package names and directories as the old passing baseline.runInReposmoke checks: local and release modes each produce the expected 12 overrides; stopped before downstream installation.pnpm exec tsc --noEmit: 25 pre-existing errors, unchanged from the clean base.The full downstream matrix remains pending PR CI; local checks do not establish remote recovery.