Repository navigation
fix(create-rstack): invalidate Nx cache when environment files change - #577
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Deploying rstack-cli with
|
| Latest commit: |
520c352
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://7c73b8e3.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-fix-nx-template-e-vgbj.rstack-cli.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d0e727af7e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changing environment files in a generated Nx workspace can reuse stale build output because Nx excludes Git-ignored files from its default cache inputs and project inputs do not cover workspace-root environment files.
Changes
Include project and workspace environment files in cache inputs with
includeIgnored: true, covering both.env*and.*.envnaming forms. Explicitly apply the named inputs to build and test tasks, including their dependencies.Validated environment-file additions, changes, and removal, plus cache hits and output restoration in a generated Nx project. Reproduced stale output after changing a workspace
.build.env, then verified the fix with workspace.build.env/.local.envand Git-ignored project.local.env. All 32 scaffold tests pass.Split from #576, which separately fixes dotenv loading precedence. Both PRs target
mainand can be merged independently.