Skip to content

fix: preserve callbacks while a refresh is pending - #147

Merged
chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-refresh-callbacks
Nov 12, 2026
Merged

chenjiahan merged 1 commit into
mainfrom
chenjiahan/fix-refresh-callbacks

Conversation

@chenjiahan

Copy link
Copy Markdown
Member

Summary

enqueueUpdate(callback) drops later callbacks while a refresh is pending, which can leave integrations waiting for a callback that never runs. Queue callbacks and run them in order after the shared refresh, including when the first call has no callback. Add minimal regression coverage for both cases and verify callbacks are not repeated in the next batch.

Related Links

Fixes #146

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-12T02:23:42.967180Z
We couldn’t complete this review. Comment @codex review to try again.
d348997 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chenjiahan
chenjiahan merged commit 67c1526 into main Nov 12, 2026
4 checks passed
@chenjiahan
chenjiahan deleted the chenjiahan/fix-refresh-callbacks branch November 12, 2026 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

enqueueUpdate(callback) drops the callback while a refresh is pending

1 participant