Test ros2 lifecycle output streams - #1266
Open
Miko997 wants to merge 1 commit into
Open
Conversation
Signed-off-by: Miko Parkkinen <141511110+Miko997@users.noreply.github.com>
|
Tick the box to add this pull request to the merge queue (same as
|
Author
|
Validated the current head |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Verify that
ros2 lifecycle setwrites command errors to stderr and successful transitions to stdout. Also require the unused stream to remain empty so regressions cannot pass through combined process output.Addresses #484
Is this user-facing behavior change?
No.
Did you use Generative AI?
No.
Additional Information
Validation:
python3 -m compileall -q ros2lifecycle/test/test_cli.pygit diff --check origin/rolling...HEADThe full ROS integration test was not run locally because this environment does not contain ROS 2 or
colcon.