Check for association with an executor before removing nodes in ComponentManager (backport #3190)#3199
Merged
Merged
Conversation
…nentManager (#3190) * add a regression test to component manager Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> * test fixture for component manager double shutdown Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> * Check in ComponentManager dtor if node is associated with an executor Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> --------- Signed-off-by: Skyler Medeiros <skye@polymathrobotics.com> Co-authored-by: Skyler Medeiros <skye@polymathrobotics.com> (cherry picked from commit d2d94d0)
Contributor
Author
|
Tick the box to add this pull request to the merge queue (same as
|
ahcorde
approved these changes
Jul 16, 2026
Contributor
|
Pulls: #3199
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the destructor of
component_managerto check each node it's removing for if it is already associated with an executor.A regression test has also been added to
test_component_manager_apiin rclcpp_components, which asserts that an exception isn't thrown during the double-removal case as outlined in #3186Fixes #3186
Is this user-facing behavior change?
Did you use Generative AI?
Claude Opus 4.8
Additional Information
This is an automatic backport of pull request #3190 done by [Mergify](https://mergify.com).