Add minimal rclpy timer example demonstrating create_timer() usage#437
Add minimal rclpy timer example demonstrating create_timer() usage#437yadnyeshwar wants to merge 3 commits into
Conversation
Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
394fd70 to
0c39f88
Compare
…amples Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
927fffe to
4ca020b
Compare
alsora
left a comment
There was a problem hiding this comment.
Adding the python file is not sufficient.
you should create a package so that the script can be "built" and installed, and then run via ros2 run
|
@yadnyeshwar this is requested changes, friendly ping. |
Signed-off-by: yadnyeshwar <yadnyeshwarasakhare@gmail.com>
Thank you for the reminder and apologies for the delayed response. I was away for a short period due to personal reasons. I have now addressed the requested changes by converting the example into an installable ROS 2 Python package so that it can be built and executed via Please let me know if there are any other adjustments you would like me to make. |
|
this still requires work.
|
|
This PR appears to have been inactive since April, and the remaining review feedback looks narrowly scoped: remove the duplicate timer script and keep the complete installable package under |
Hi @dlanov , thank you for following up. I'm still interested in completing this contribution and continuing to contribute to ROS 2. I've been reviewing the current state of this PR against the latest rolling branch and noticed that the repository structure has changed since the original review. Before updating the branch, I'd like to confirm whether you would still prefer the installable package to live under rclpy/timers/minimal_timer as mentioned in the earlier review, or if you'd prefer the PR to follow the current repository layout. I'm happy to update the PR accordingly. Thank you! |
|
@yadnyeshwar |
This PR adds a minimal example demonstrating how to use
create_timer()in rclpy.While the minimal publisher example already uses a timer internally,
this example focuses specifically on timer usage without publishing.
This provides a simple reference for beginners learning
periodic execution in ROS 2.
Closes #436