Skip to content

Repository navigation

chore(deps): bump rustls to 0.23.46, remove zip deps, check updater feed formats #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aavshr wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(deps): bump rustls to 0.23.46, remove zip deps, check updater feed formats #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 27 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ jobs:
if: needs.prepare.outputs.release == 'true'
runs-on: ubuntu-22.04
steps:
- name: Every platform is in latest.json
- name: Every platform has an installable bundle in latest.json
env:
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
TAG: ${{ needs.prepare.outputs.tag }}
Expand All @@ -271,18 +271,39 @@ jobs:
gh release download "$TAG" \
--repo "$GITHUB_REPOSITORY" --pattern latest.json --dir .

missing=0
# Feed URLs are asset API links, so map them back to file names.
gh release view "$TAG" --repo "$GITHUB_REPOSITORY" \
--json assets -q '.assets[] | "\(.apiUrl) \(.name)"' > assets.txt

# The updater is built without its `zip` feature (src-tauri/Cargo.toml), so Windows and
# Linux take only a bare installer. A zipped one fails on Windows, and on Linux a
# .AppImage.tar.gz is written over the AppImage as-is, which breaks the install.
failed=0
for platform in darwin-aarch64 darwin-x86_64 linux-x86_64 windows-x86_64; do
url=$(jq -r --arg p "$platform" '.platforms[$p].url // ""' latest.json)
signature=$(jq -r --arg p "$platform" '.platforms[$p].signature // ""' latest.json)
if [ -z "$url" ] || [ -z "$signature" ]; then
echo "::error::latest.json has no signed bundle for $platform"
missing=1
else
echo "$platform -> $url"
failed=1
continue
fi

name=$(awk -v u="$url" '$1 == u { print $2 }' assets.txt)
if [ -z "$name" ]; then
echo "::error::$platform points at $url, which is not an asset of $TAG"
failed=1
continue
fi

case "$platform:$name" in
darwin-*:*.app.tar.gz | linux-*:*.AppImage | windows-*:*-setup.exe | windows-*:*.msi)
echo "$platform -> $name" ;;
*)
echo "::error::$platform points at $name, a format this updater cannot install"
failed=1 ;;
esac
done
exit "$missing"
exit "$failed"

# A plain version moves the updater feed. A pre-release is published but offered to nobody.
publish:
Expand Down
40 changes: 3 additions & 37 deletions src-tauri/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 3 additions & 1 deletion src-tauri/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,9 @@ tauri-plugin-opener = "2"
tauri-plugin-fs = "2"
tauri-plugin-dialog = "2"
tauri-plugin-window-state = "2"
tauri-plugin-updater = "2"
# No `zip` feature: it only unpacks zipped Windows installers and tar.gz AppImages, and the feed
# ships a bare setup.exe and AppImage (`createUpdaterArtifacts: true`). macOS tar.gz is unaffected.
tauri-plugin-updater = { version = "2", default-features = false, features = ["rustls-tls", "system-proxy"] }
# Asking the OS is the only honest answer to "am I registered"; a settings bool would drift.
tauri-plugin-autostart = "2"
serde = { version = "1", features = ["derive"] }
Expand Down
Loading