Skip to content

[TEST][NO MERGE] Feat/test reimagine cr#154

Open
amaury901130 wants to merge 10 commits into
masterfrom
feat/test-reimagine-cr
Open

[TEST][NO MERGE] Feat/test reimagine cr#154
amaury901130 wants to merge 10 commits into
masterfrom
feat/test-reimagine-cr

Conversation

@amaury901130

Copy link
Copy Markdown
Collaborator

Jira board reference:


What does this do?

Adds local Pushgate pre-push checks to the template with a committed .pushgate.yml configuration and documents the workflow in both template readmes. The config uses target_branch: master, starts AI review in advisory mode, and adds blocking deterministic checks for type-check, eslint, lint, lint:translations, and test, plus diff_size and forbidden_paths policies. This PR also updates the project creation CLI so new apps created with create-rootstrap-rn-app attempt to install Pushgate automatically after dependency installation.


Why did you do this?

The template now recommends Pushgate, but hooks are local and not tracked by git. Automating installation in the scaffold flow reduces onboarding misses, and documenting manual install/verification keeps existing clones and edge cases covered while ensuring the local checks stay consistent across new apps.

Who/what does this impact?

  • Developers creating apps from this template via create-rootstrap-rn-app.
  • Existing clones of this repository that need manual Pushgate installation.
  • CI/runtime app behavior is unaffected; changes are limited to local dev workflow and docs.

How did you test this?

  • Tested on iOS
  • Tested on Android
  • Tested on a small device
  • Tested on a real device
  • Tested all flows related with this PR changes
  • Tested accessibility
  • Added tests

Notes:

  • Pushgate auto-install in the CLI is best-effort: if install fails (for example network/curl availability), project creation continues and docs include the manual installer command.

Screenshots / Previews

N/A — tooling and documentation changes only.

Copilot AI review requested due to automatic review settings July 7, 2026 19:49
@amaury901130 amaury901130 requested a review from a team as a code owner July 7, 2026 19:49
@amaury901130 amaury901130 added the risk:low Config, copy, minor UI tweaks. Low blast radius. label Jul 7, 2026
@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

💯 Test Coverage

Lines Statements Branches Functions
Coverage: 56%
56.23% (347/617) 59.18% (174/294) 48.76% (118/242)

😎 Tests Results

Tests Skipped Failures Errors Time
139 0 💤 0 ❌ 0 🔥 35.181s ⏱️
👀 Tests Details • (56%)
File% Stmts% Branch% Funcs% LinesUncovered Line #s
All files56.2359.1848.7656.9 
report-only-changed-files is enabled. No files were changed in this commit :)

@label-pr-severity-rs label-pr-severity-rs Bot added the ai:clean No significant issues label Jul 7, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds local Pushgate pre-push checks to the template (with a committed .pushgate.yml), documents the workflow in the readmes/PR template, and updates the project creation CLI to best-effort install Pushgate during scaffolding. It also introduces a (currently active) “layer4-gatekeeper” GitHub Actions workflow + script for routing/approval gating based on risk:* + ai:* labels.

Changes:

  • Add a committed Pushgate v2 configuration and document installation/skip workflows.
  • Update create-rootstrap-rn-app CLI flow to attempt Pushgate installation after pnpm install.
  • Add risk-classification guidance and add a gatekeeper workflow/script for label-based merge gating.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Documents risk label system and Pushgate local hook usage.
README-project.md Mirrors Pushgate + risk label documentation for generated projects.
cli/setup-project.js Adds installPushgate() (curl installer) and exports it.
cli/index.js Calls installPushgate() after dependency installation.
.pushgate.yml Adds Pushgate v2 config (AI advisory + blocking deterministic checks).
.husky/pre-push Adds Husky pre-push hook intended to run Pushgate.
.github/workflows/layer4-gatekeeper.disabled.yml Adds a workflow intended to be “disabled” but currently would run.
.github/scripts/gatekeeper.js Implements routing logic and sets a commit status based on labels + approvals.
.github/PULL_REQUEST_TEMPLATE.md Adds a “Layer 2” risk classification section.
.github/copilot-instructions.md Adds Copilot review conventions and classification rubric.
.agents/skills/pr-description/SKILL.md Updates PR-description skill guidance to include risk classification.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .husky/pre-push Outdated
Comment thread .github/workflows/layer4-gatekeeper.disabled.yml
Comment thread cli/setup-project.js
@label-pr-severity-rs label-pr-severity-rs Bot added ai:serious Security concerns, logic errors and removed ai:clean No significant issues labels Jul 7, 2026
@amaury901130 amaury901130 changed the title Feat/test reimagine cr [TEST][NO MERGE] Feat/test reimagine cr Jul 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 9 comments.

Comment thread cli/utils.js
Comment thread .github/workflows/layer4-gatekeeper.disabled.yml
Comment thread .husky/pre-push
Comment thread .husky/pre-push
Comment thread .husky/pre-push
Comment thread .husky/pre-push
Comment thread cli/setup-project.js
Comment thread README.md
Comment thread README-project.md
@label-pr-severity-rs label-pr-severity-rs Bot added ai:serious Security concerns, logic errors and removed ai:serious Security concerns, logic errors labels Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai:serious Security concerns, logic errors risk:low Config, copy, minor UI tweaks. Low blast radius.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants