Repository navigation
Migrate releases to release-please - #83
Merged
Merged
Conversation
Adds release-please (googleapis/release-please-action v5) to own the version bump, tag, and GitHub release. The publish workflow gains a workflow_dispatch trigger and is kicked off automatically when release-please cuts a release (GITHUB_TOKEN-created tags don't fire push/tags triggers). The release-drafter workflow is removed; the oasdiff OpenAPI-changelog job is ported into release-please.yml as a post-release job that appends an 'API changes' section and uploads openapi-diff.md as a release asset. Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Adds a release job gated on push events that creates the GitHub release when none exists (manual v* tag pushes). The release-please dispatch path is unaffected — this job only runs on push, and the release already exists there. Replaces the removed draft-publish tail job. Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
steps.release.outputs.* is only valid inside the job that defined them — the openapi-diff job ran 'if' on an empty context, which fails workflow instantiation. The release-please job now maps the outputs and openapi-diff reads them via needs.release-please.outputs.*. Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Self-review pass (Devin):
- Manifest
3.0.0matches latest remote tagv3.0.0; trigger onmaster; config + workflow YAML parse clean. - Fixed a real bug found in review:
openapi-diffreferencedsteps.release.outputs.*from a different job —stepsisn't a valid job-level context, so workflow instantiation failed (visible as zero-job failed runs on this branch). Outputs are now mapped vianeeds.release-please.outputs.*. - Added
releasejob (push-only) so manualv*tag pushes still get a GitHub release. - Updated stale release docs in CLAUDE.md + PUBLISHING.md (still referenced Release Drafter).
- CI: all green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves releases to release-please, matching rootly-desktop / rootly-mcp-server / rootly-go. Replaces release-drafter + manual tagging: a release PR opens on pushes to
master, and merging it cuts the tag, GitHub release, and dispatch topublish.yml(a GITHUB_TOKEN-created tag does not firepush: tags, hence the dispatch).release-please-config.json+.release-please-manifest.json(seeded at 3.0.0);build.gradle'sversion = '3.0.0'is bumped by the generic updater via anx-release-please-versionmarkerrelease-please.ymlrunsgoogleapis/release-please-actionv5, thengh workflow run publish.yml --ref $TAG, plus anopenapi-diffjob ported from the old release-drafter workflow (oasdiff onapi/openapi.yaml, uploadsopenapi-diff.md+ appends an API-changes section to the release body)publish.ymlgainsworkflow_dispatch; the draft-release tail job is deletedrelease-drafter.yml+.github/release-drafter.ymldeletedManual
v*tag pushes still run publish as before. Rollback = revert this PR.Link to Devin session: https://rootly.devinenterprise.com/sessions/774103253f13428589402ae6862eeaeb
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/774103253f13428589402ae6862eeaeb?variant=devin
Requested by: @kwent