Repository navigation
Conversation
…uation, wide tables, exit codes) Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
There was a problem hiding this comment.
✅ Devin resolved all 8 findings on 4124472
Fixed by Devin (8)
- Loading status persists after history finishes
- Late history corrupts an active chat
- Longer fence closers hide subsequent tables
- Escaped backslashes merge table columns
- Header-only wide tables disappear
- Escaped pipes corrupt table values
- Tables inside long fences get rewritten
- Three trailing backslashes submit unexpectedly
…tact Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
[Medium impact] The PR appears safe to merge as part of the supplied stack, with PR #79 required for the queue-related clearances. SummaryThis PR polishes the agent’s welcome screen, composer, tables, activity messages, MCP notices, and print-mode exit codes.
Reviews (5) · Last reviewed commit: "refactor(agent): move history handling o..." · Reviewed by Greptile |
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
… on one snapshot Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
|
@greptileai review |
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
|
@greptileai review |
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
|
@greptileai review |
Co-Authored-By: Quentin Rousseau <quentin@rootly.com>
|
@greptileai review |
|
🤖 Completed real-terminal/tmux E2E on final head Requested runtime checks passed:
Coverage boundary: Queued skill prompts and queue cancellation via One recording, motion-trimmed to 40.8 seconds, with an animated WebP derived from that same recording:
No implementation changes or GitHub posting. Real |
Summary
Why:
rootly-ai-tuiis being abandoned in favour of the hiddenrootly agent/rootly chat. This ports the small UX items from the reverse audit (rows 17/18/22/24/27/37/40/47/52/62/63/82/87/94). Stacked on #75. CLI only.What
Welcome back, <first name> · <team>, the cwd (~-abbreviated), the API host, andAsk me about incidents, alerts and on-callonly when it fits the width. The pulse logo is unchanged and stays centred beside the rows.View().ReportFocus = true.tea.BlurMsgdraws a hollow▢cursor,tea.FocusMsgrestores the solid one. Bubble Tea parses the focus sequences, so they never reach the composer.\+ Enter becomes a newline (\\still submits). When the composer scrolls,↑ N more linesshows above it.bulletizeWideTablesruns inprepareAssistantMarkdown. A table wider than the render width becomes- **cell1** · Header2: cell2 · …. Tables inside fences and tables that fit are left as they are.✗. No-color output stays plain.Session not found — starting a new chatand callsstartNewSession().MCP 'x' unreachable: <reason> — open /mcp.client_tools_accepted > 0printsN local tools availableonce.NotAuthenticatedError(no credentials, or a 401 from preflight or the stream) becomes exit code 2 in print mode viaPrintExitError/ExitCodeError. Other errors stay at 1. The codes are documented inrootly agent --help.Verify binarynow also runs./bin/rootly --version.exit/quit) was already in place viaisExitAlias, with tests.Not done: the welcome block has no role row.
rootly-go'sCurrentUseronly has the role id,/v1/users/me?include=rolereturns no included role, and/v1/roles/{id}404s for a user's built-in role. Showing a role needs an API change, which is out of scope here (CLI only).Risk: low. The changes are display-only, plus the print-mode exit code for unauthenticated runs.
Rollback: revert this PR.
Link to Devin session: https://rootly.devinenterprise.com/sessions/5e2e52b477b74d98b9ed9500fe7b4860
Open in Devin Desktop: https://rootly.devinenterprise.com/desktop/session/5e2e52b477b74d98b9ed9500fe7b4860?variant=devin
Requested by: @kwent